Skip to content

Address additional errors found in native rules implementation - #533

Merged
jonbodner-buf merged 1 commit into
mainfrom
jbodner/fix_native_bugs
Oct 1, 2026
Merged

Address additional errors found in native rules implementation#533
jonbodner-buf merged 1 commit into
mainfrom
jbodner/fix_native_bugs

Conversation

@jonbodner-buf

@jonbodner-buf jonbodner-buf commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

Issues resolved:

  • a protovalidate rule on a repeated google.protobuf.Int32Value caused a panic
  • a string.min_len on a map<string, google.protobuf.StringValue> was ignored
  • order of rule violations did not match validate.proto
  • unique wasn't respected on a repeated google.protobuf.Int32Value
  • custom CEL rules are evaluated twice if there's a standard rule as well

Tests expanded to cover these cases.

@jonbodner-buf
jonbodner-buf requested a review from pkwarren October 1, 2026 19:31
@jonbodner-buf
jonbodner-buf merged commit 8358391 into main Oct 1, 2026
5 checks passed
@jonbodner-buf
jonbodner-buf deleted the jbodner/fix_native_bugs branch October 1, 2026 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pkwarren pkwarren pkwarren approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jonbodner-buf @pkwarren